fix: Prop spreading for Tree #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcullman
reviewed
Jan 18, 2019
| @@ -146,7 +146,7 @@ export class Tree extends Component { | |||
| role='treeitem'> | |||
| <div className='fd-tree__row'> | |||
| {parent} | |||
| {<Dropdown isContextual />} | |||
| {<Dropdown />} | |||
There was a problem hiding this comment.
did we ever get an answer on this isContexual prop?
There was a problem hiding this comment.
Yes, @chrismanciero found a commit where it was removed from Dropdown, but apparently just missed in a few of the places that called it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The API doesn't easily allow for prop spreading to elements below the header and list so I did a few of them in this PR and created #265 for the follow-up work.